fix(v8): expose diagnostics and serialization surface#3428
Merged
proggeramlug merged 15 commits intoMay 31, 2026
Merged
Conversation
This was referenced May 30, 2026
# Conflicts: # crates/perry-hir/src/lower/expr_new.rs
Contributor
Author
|
Updated this branch for the latest mainline changes.
|
# Conflicts: # docs/api/perry.d.ts # docs/src/api/reference.md
Contributor
Author
|
Refreshed this branch again after mainline moved.
|
# Conflicts: # docs/api/perry.d.ts # docs/src/api/reference.md
Contributor
Author
|
Refreshed this branch for the latest mainline changes.
|
Contributor
Author
|
Fixed the cargo-test manifest consistency failure on this branch.
|
added 4 commits
May 31, 2026 11:14
# Conflicts: # crates/perry-api-manifest/src/entries.rs # crates/perry-hir/src/destructuring/var_decl.rs # crates/perry-hir/src/lower/expr_member.rs # crates/perry-hir/src/lower/module_decl.rs # crates/perry-runtime/src/object/native_module.rs # docs/api/perry.d.ts # docs/src/api/reference.md
# Conflicts: # docs/api/perry.d.ts # docs/src/api/reference.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node:v8namespace withserialize/deserialize, diagnostic heap/code/space statistic shapes, and cached-data version tag support.Serializer,DefaultSerializer,Deserializer, andDefaultDeserializerconstructor/method surfaces through manifest, lowering, codegen, and runtime dispatch.node:v8APIs and class-based serialization.Closes #3137. Closes #3138. Closes #3294.
Batching rationale
These three issues share the same
node:v8public namespace, native module registration path, runtime dispatch table, manifest entries, and V8 wire codec. Splitting them would duplicate the namespace and constructor plumbing while leaving the parity fixture artificially fragmented.Tests
PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH ./run_parity_tests.sh --suite node-suite --module v8/diagnostics-serialization --filter first-slicePATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH ./run_parity_tests.sh --suite node-suite --module v8RUSTC_WRAPPER= cargo check -p perry-runtime -p perry-hir -p perry-codegen -p perry-api-manifest -p perryRUSTC_WRAPPER= cargo test -p perry-api-manifestcargo fmt --all -- --checkgit diff --check./scripts/check_file_size.shjq empty test-parity/known_failures.jsonKnown limitations / non-goals
writeUint32/readUint32are minimal surface implementations.promiseHooks, startup snapshots, heap snapshots, or CPU/heap profiling APIs tracked by adjacentnode:v8issues.