fix(util): implement diff helper#3462
Merged
proggeramlug merged 4 commits intoMay 31, 2026
Merged
Conversation
Contributor
Author
|
Fixed the API docs drift on this branch.
|
eed1026 to
289c784
Compare
289c784 to
0c1d09f
Compare
added 2 commits
May 31, 2026 09:09
# Conflicts: # crates/perry-runtime/src/object/native_module.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3433
Summary
util.diff(actual, expected)for string inputs, arrays of strings, and mixed string/string-array inputs.[]behavior and common tuple output for identical string arrays.ERR_INVALID_ARG_TYPEvalidation for unsupported inputs and non-string array elements.Tests
PATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH ./run_parity_tests.sh --suite node-suite --module util --filter diffPATH=/home/github-runner/actions-runner/externals/node24/bin:$PATH ./run_parity_tests.sh --suite node-suite --module util(72/73 passed; existingnode-suite/util/get-system-errormismatch remains)RUSTC_WRAPPER= cargo check -p perry-runtime -p perry-codegen -p perry-api-manifest -p perry-hir -p perrycargo fmt --all -- --checkgit diff --checkjq empty test-parity/known_failures.json./scripts/check_file_size.sh