[codex] Fix object numeric index assignment#4176
Merged
proggeramlug merged 1 commit intoJun 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
obj[1] = valuecreating/updating property"1"Scan notes
Initial baseline after building only the Perry CLI was infrastructure noise:
scripts/test262_focused_report.py --root vendor/test262 --dir language/expressions --max 500 --sample-cap 1000000 --timeout 20reported 285 compile-fail, allError: Could not find libperry_runtime.a.After building static archives with
cargo build --release -p perry-runtime -p perry-stdlib, the same baseline was real parity signal: 500 judged, 482 pass, 18 runtime-fail, 0 compile-fail, 0 skip.The fixed failures were:
language/expressions/assignment/S8.12.5_A1.js:obj[1] = ...did not create property"1"language/expressions/assignment/S8.12.5_A2.js:obj[1] = ...did not overwrite existing property"1"Post-fix
language/expressions --max 500: 500 judged, 484 pass, 16 runtime-fail, 0 compile-fail, 0 skip.Focused assignment follow-up:
scripts/test262_focused_report.py --root vendor/test262 --dir language/expressions/assignment --max 500 --sample-cap 1000000 --timeout 20 --skip-vendor --skip-buildreported 207 judged, 196 pass, 11 runtime-fail, 0 compile-fail, 0 skip;S8.12.5_A1/A2no longer appear in the problem TSV.Validation
cargo build --release -p perry-runtime -p perrycargo fmt --package perry-runtime --checktests/test_c262_object_numeric_index_assignment.shscripts/test262_focused_report.py --root vendor/test262 --dir language/expressions/assignment --max 500 --sample-cap 1000000 --timeout 20 --skip-vendor --skip-buildscripts/test262_focused_report.py --root vendor/test262 --dir language/expressions --max 500 --sample-cap 1000000 --timeout 20 --skip-vendor --skip-build