Skip to content

Unit image changes in various theater types - #2322

Open
obsidian14 wants to merge 4 commits into
Phobos-developers:developfrom
obsidian14:feature/theater
Open

Unit image changes in various theater types#2322
obsidian14 wants to merge 4 commits into
Phobos-developers:developfrom
obsidian14:feature/theater

Conversation

@obsidian14

@obsidian14 obsidian14 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Unit image changes in various theater types

  • Units on maps of different theater types can now change their models to the corresponding theater-specific models.
  • The INI tags are shown below.

In rulesmd.ini:

[SOMEVEHICLE]                         ; VehicleType
Image.Temperate=                      ; VehicleType entry
Image.Snow=                           ; VehicleType entry
Image.Urban=                          ; VehicleType entry
Image.Desert=                         ; VehicleType entry
Image.NewUrban=                       ; VehicleType entry
Image.Lunar=                          ; VehicleType entry

@phoboscn-bot

Copy link
Copy Markdown

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户:
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息:

https://www.phoboscn.top/t/topic/692/1

@NetsuNegi NetsuNegi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to use Nullable in this PR for now

Comment thread src/Ext/UnitType/Body.h
Nullable<UnitTypeClass*> Image_Urban;
Nullable<UnitTypeClass*> Image_Desert;
Nullable<UnitTypeClass*> Image_NewUrban;
Nullable<UnitTypeClass*> Image_Lunar;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Nullable<UnitTypeClass*> Image_Lunar;
Valueable<UnitTypeClass*> Image_Lunar;

Comment thread src/Ext/UnitType/Body.h
Nullable<UnitTypeClass*> Image_Snow;
Nullable<UnitTypeClass*> Image_Urban;
Nullable<UnitTypeClass*> Image_Desert;
Nullable<UnitTypeClass*> Image_NewUrban;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Nullable<UnitTypeClass*> Image_NewUrban;
Valueable<UnitTypeClass*> Image_NewUrban;

Comment thread src/Ext/UnitType/Body.h
Nullable<UnitTypeClass*> Image_Temperate;
Nullable<UnitTypeClass*> Image_Snow;
Nullable<UnitTypeClass*> Image_Urban;
Nullable<UnitTypeClass*> Image_Desert;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Nullable<UnitTypeClass*> Image_Desert;
Valueable<UnitTypeClass*> Image_Desert;

Comment thread src/Ext/UnitType/Body.h

Nullable<UnitTypeClass*> Image_Temperate;
Nullable<UnitTypeClass*> Image_Snow;
Nullable<UnitTypeClass*> Image_Urban;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Nullable<UnitTypeClass*> Image_Urban;
Valueable<UnitTypeClass*> Image_Urban;

Comment thread src/Ext/UnitType/Body.h
Valueable<int> BurstPerTurret;

Nullable<UnitTypeClass*> Image_Temperate;
Nullable<UnitTypeClass*> Image_Snow;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Nullable<UnitTypeClass*> Image_Snow;
Valueable<UnitTypeClass*> Image_Snow;

Comment thread src/Ext/UnitType/Body.h
std::vector<CoordStruct> ExtraTurretOffsets;
Valueable<int> BurstPerTurret;

Nullable<UnitTypeClass*> Image_Temperate;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Nullable<UnitTypeClass*> Image_Temperate;
Valueable<UnitTypeClass*> Image_Temperate;

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants