Repository navigation
feat(oauth): design the RP-initiated logout pages - #38
Merged
Merged
Conversation
The OAuth provider plugin answers browser logout requests with unstyled HTML it can't be configured to restyle. The auth handler now redirects those pages to /logout, carrying the plugin's cookies, and the new route renders the confirm, signed-out, and error states in the login card layout.
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an app signs a user out through
/oauth2/end-session, the OAuth provider plugin answers with bare, unstyled HTML. The plugin has no option to restyle it.src/routes/api/auth/$.ts: for end-session requests, the handler recognises the plugin's logout pages by theirdata-oidc-logout-*markers. It answers with a 303 to/logoutand keeps everySet-Cookie, including the signed confirmation cookie. The plugin still owns the protocol logic.src/routes/logout.tsx: a new page in the login card layout, with three states:/api/auth/oauth2/end-session/confirm.Screenshots
Testing
src/auth/logout-page.test.tscovers detecting each page, keeping the cookies through the redirect, and leaving other responses untouched./logout→ Sign out deletes the session and lands on the signed-out page.vp lint,vp fmt --check, andvp testpass.