fix: Prevent auto-generated title from overwriting manual rename#1676
Merged
charlesvien merged 3 commits intomainfrom Apr 16, 2026
Merged
Conversation
charlesvien
changed the title
This was referenced Apr 15, 2026
Member
Author
This was referenced Apr 15, 2026
charlesvien
force-pushed
the
04-15-prevent_auto-generated_title_from_overwriting_manual_rename
branch
from
90ebf0c to
94a8ce6
Compare
charlesvien
force-pushed
the
04-15-add_task_search_and_sidebar_context_menu_integration_to_command_center
branch
from
000d5bb to
e96a20f
Compare
charlesvien
force-pushed
the
04-15-prevent_auto-generated_title_from_overwriting_manual_rename
branch
2 times, most recently
from
3124ffd to
2b53d3c
Compare
charlesvien
force-pushed
the
04-15-add_task_search_and_sidebar_context_menu_integration_to_command_center
branch
2 times, most recently
from
f4cd928 to
2fa6f55
Compare
charlesvien
force-pushed
the
04-15-prevent_auto-generated_title_from_overwriting_manual_rename
branch
from
2b53d3c to
37f4016
Compare
jonathanlab
approved these changes
Apr 16, 2026
charlesvien
changed the base branch from
04-15-add_task_search_and_sidebar_context_menu_integration_to_command_center
to
graphite-base/1676
charlesvien
force-pushed
the
graphite-base/1676
branch
from
2fa6f55 to
e4e18ed
Compare
charlesvien
force-pushed
the
04-15-prevent_auto-generated_title_from_overwriting_manual_rename
branch
from
37f4016 to
0706ec0
Compare
charlesvien
force-pushed
the
04-15-prevent_auto-generated_title_from_overwriting_manual_rename
branch
from
0706ec0 to
273252c
Compare
Member
Author
Merge activity
|
charlesvien
deleted the
04-15-prevent_auto-generated_title_from_overwriting_manual_rename
branch
vdekrijger
pushed a commit
that referenced
this pull request
Apr 16, 2026
## Problem Auto-title generation silently bypassed the title_manually_set guard because getQueryData used exact key matching while task queries include filter objects in their keys. Closes https://github.com/PostHog/code/issues/1669<!-- Who is this for and what problem does it solve? --> <!-- Closes #ISSUE_ID --> ## Changes 1. Fix cache lookup in useChatTitleGenerator to use getQueriesData (prefix match) instead of getQueryData (exact match) 2. Add title_manually_set guard to generateTaskTitle at task creation time <!-- What did you change and why? --> <!-- If there are frontend changes, include screenshots. --> ## How did you test this? Manually <!-- Describe what you tested -- manual steps, automated tests, or both. --> <!-- If you're an agent, only list tests you actually ran. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Auto-title generation silently bypassed the title_manually_set guard because getQueryData used exact key matching while task queries include filter objects in their keys.
Closes #1669
Changes
How did you test this?
Manually