chore: remove use of six and mock#442
Open
s-t-e-v-e-n-k wants to merge 2 commits intoPostHog:mainfrom
Open
Conversation
Contributor
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
s-t-e-v-e-n-k
force-pushed
the
remove-mock-and-six
branch
from
a41965e to
7467997
Compare
Member
|
@s-t-e-v-e-n-k can you rebase and target the main branch instead? thanks for the PR |
mock has been in the standard library since Python 3.3, and six stopped being required when Python 2 support was dropped, so remove both of them.
s-t-e-v-e-n-k
force-pushed
the
remove-mock-and-six
branch
from
7467997 to
2196860
Compare
Author
Done! |
Member
you still need to force push with a signed commit, sorry forgot to mention that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mock has been in the standard library since Python 3.3, and six stopped being required when Python 2 support was dropped, so remove both of them.