Add invoke_dsc_function() and invoke_dsc_expression() tools to Server mode#1588
Open
SteveL-MSFT wants to merge 3 commits into
Open
Add invoke_dsc_function() and invoke_dsc_expression() tools to Server mode#1588SteveL-MSFT wants to merge 3 commits into
invoke_dsc_function() and invoke_dsc_expression() tools to Server mode#1588SteveL-MSFT wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends DSC “server” mode by adding two new JSON-RPC tools—invoke_dsc_expression and invoke_dsc_function—and updates server-mode localization keys to use the server.* namespace (instead of mcp.*).
Changes:
- Added
invoke_dsc_expressionandinvoke_dsc_functiontool implementations and registered them with the server tool router. - Renamed server-mode i18n keys from
mcp.*toserver.*and updated call sites accordingly. - Expanded Pester coverage to validate the new tools via
tools/call.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| dsc/tests/dsc_server.tests.ps1 | Adds Pester coverage for invoke_dsc_expression / invoke_dsc_function and updates the expected tool list. |
| dsc/src/server/invoke_dsc_expression.rs | Implements the new invoke_dsc_expression tool. |
| dsc/src/server/invoke_dsc_function.rs | Implements the new invoke_dsc_function tool. |
| dsc/src/server/mcp_server.rs | Registers the new tool routers and updates server instructions i18n key. |
| dsc/src/server/mod.rs | Exposes the new server modules and updates i18n key usage. |
| dsc/src/server/invoke_dsc_config.rs | Updates i18n keys from mcp.* to server.*. |
| dsc/src/server/invoke_dsc_resource.rs | Updates i18n keys from mcp.* to server.*. |
| dsc/src/server/list_dsc_functions.rs | Updates i18n keys from mcp.* to server.*. |
| dsc/src/server/list_dsc_resources.rs | Updates i18n keys from mcp.* to server.*. |
| dsc/src/server/show_dsc_resource.rs | Updates i18n keys from mcp.* to server.*. |
| dsc/locales/en-us.toml | Moves server-mode strings under [server.*] and adds strings for the new tools. |
83a2352 to
21cfeb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
serverinstead ofmcpinvoke_dsc_function()andinvoke_dsc_expression()toolsrmcpcrate doesn't allow direct use ofserde_json::Valuetype, so need a wrapper enum to make it work.PR Context
For you @ThomasNieto :)