Repository navigation
Bump chai from 4.4.1 to 5.1.1 - #157
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [chai](https://github.com/chaijs/chai) from 4.4.1 to 5.1.1. - [Release notes](https://github.com/chaijs/chai/releases) - [Changelog](https://github.com/chaijs/chai/blob/main/History.md) - [Commits](chaijs/chai@v4.4.1...v5.1.1) --- updated-dependencies: - dependency-name: chai dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
the
dependencies
rom1504
left a comment
rom1504
left a comment
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
Not ready to merge at d073fbd: Migrate Chai ESM imports or align tested Node floor, then run ProtoDef suite.
Validation: current head and discussion rechecked; this review uses the source, CI and focused evidence collected for this same head earlier today. No additional full-suite run in this publication pass.
Skills used: prismarine-review checked the current diff, discussion and validation; prismarine-architecture-review checked the dependency change against the package’s actual consumers and public contract.
| "devDependencies": { | ||
| "benchmark": "^2.1.4", | ||
| "chai": "^4.1.2", | ||
| "chai": "^5.1.1", |
There was a problem hiding this comment.
Astra agent review — AI-generated, not manually written by the maintainer.
The candidate workflow explicitly runs Node 14, but the datatype tests still use require("chai").expect and Chai 5 is ESM-only. On that test runtime this fails before the codec assertions execute. Please migrate the test import/runner setup or deliberately update the test-runtime policy, then run the actual ProtoDef suite. Modern Node 24 require(ESM) compatibility does not validate the retained Node 14 job.
Skills used: prismarine-review checked the current diff, discussion and validation; prismarine-architecture-review checked the dependency change against the package’s actual consumers and public contract.
1 participant
Bumps chai from 4.4.1 to 5.1.1.
Release notes
Sourced from chai's releases.
... (truncated)
Commits
37263c0fix: support some virtual contexts intoThrow(#1609)91e58edCorrect Mocha import instructions (#1611)61159d1build(deps-dev): bump ip from 1.1.8 to 1.1.9 (#1608)8475d2aSet up ESLint for JSDoc comments (#1605)936c0ca5.1.02cf92f5Fix publish script (#1602)1ba37b5Set support in same members (#1583)f224339Assert interface fix (#1601)d504573Implementiterableassertion (#1592)640d932Convert comments in "legal comments" format to jsdoc (#1598)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)