Skip to content

Make Codec.is_encoder a property #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WyattBlue merged 1 commit into from
Aug 15, 2026
+4 −5
Merged

Make Codec.is_encoder a property #2375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions av/codec/codec.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ cdef class Codec:

cdef const lib.AVCodec *ptr
cdef const lib.AVCodecDescriptor *desc
cdef readonly bint is_encoder

cdef tuple[HWConfig, ...] _hardware_configs

cdef _init(self, name=?)
Expand Down
7 changes: 4 additions & 3 deletions av/codec/codec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
def wrap_codec(ptr: cython.pointer[cython.const[lib.AVCodec]]) -> Codec:
codec: Codec = Codec(_cinit_sentinel)
codec.ptr = ptr
codec.is_encoder = lib.av_codec_is_encoder(ptr)
codec._init()
return codec

Expand Down Expand Up @@ -135,8 +134,6 @@ def _init(self, name=None):
if not self.desc:
raise RuntimeError(f"No codec descriptor for {name!r}.")

self.is_encoder = lib.av_codec_is_encoder(self.ptr)

# Sanity check.
if self.is_encoder and lib.av_codec_is_decoder(self.ptr):
raise RuntimeError("%s is both encoder and decoder.")
Expand All @@ -154,6 +151,10 @@ def create(self, kind=None):

return CodecContext.create(self)

@property
def is_encoder(self):
return bool(lib.av_codec_is_encoder(self.ptr))

@property
def mode(self):
return "w" if self.is_encoder else "r"
Expand Down
Loading