Conversation
A FilterContext held a weakref to its Graph, so dropping the Graph freed the underlying AVFilterContext while the context was still held. Using it (push/link_to/process_command) then dereferenced freed memory. Make `_graph` a strong ref; the Graph<->context cycle is collected by gc.
- push() to a buffer source before the graph is configured dereferenced uninitialized graph internals. Auto-configure first, mirroring pull(). - add_stream_from_template() dereferenced a template Stream's AVStream ptr without checking its source container was still open. Guard with _assert_open().
FilterPad.__repr__ and FilterContextPad.__repr__ referenced self.type, which was never defined, so repr() of any pad raised AttributeError. Add a type property via avfilter_pad_get_type, mirroring the name property.
`_context_by_type` already indexes them, which is how the sink side reads its contexts.
__basicsize__ 80 -> 72.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A FilterContext held a weakref to its Graph, so dropping the Graph freed the underlying AVFilterContext while the context was still held. Using it (push/link_to/process_command) then dereferenced freed memory. Make
_grapha strong ref; the Graph<->context cycle is collected by gc.