feat: Add the shared client theme object on message sent and in message object#3209
feat: Add the shared client theme object on message sent and in message object#3209UnBonWhisky wants to merge 26 commits into
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3209/head:pr-3209
git checkout pr-3209This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3209/head |
|
Note : shared client theme should not work with components v2 (source: Discord docs) but it works.
|
plun1331
left a comment
There was a problem hiding this comment.
Since shared client theme is constructible, I feel like we should add methods like set_colors and whatnot to make that easier
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: Flavien F <65244389+UnBonWhisky@users.noreply.github.com>
Co-authored-by: plun1331 <plun1331@gmail.com> Signed-off-by: Flavien F <65244389+UnBonWhisky@users.noreply.github.com>
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com> Signed-off-by: Flavien F <65244389+UnBonWhisky@users.noreply.github.com>
Signed-off-by: Paillat <paillat@pycord.dev>
Or just properties with setters |
|
Just a couple of nitpicks:
|
…aclass initialization
Paillat-dev
left a comment
There was a problem hiding this comment.
I wonder if you can respond to interactions with a shared client theme. Probably not.
Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: UnBonWhisky <65244389+UnBonWhisky@users.noreply.github.com>
Paillat-dev
left a comment
There was a problem hiding this comment.
Seems good enough to me, thanks for the PR ! Just a couple nitpicks.
| ---------- | ||
| colours: List[:class:`Colour`] | ||
| The colours of the theme. A maximum of 5 colours. | ||
| colors: List[:class:`Colour`] |
There was a problem hiding this comment.
Should be documented in the property method not here since it's not an attribute technically.
|
|
||
| ### Added | ||
|
|
||
| - Added `SharedClientTheme` object for sending and receiving client themes. |
There was a problem hiding this comment.
| - Added `SharedClientTheme` object for sending and receiving client themes. | |
| - Added support for sending and receiving client themes. |

Caution
Feature freeze is active, as described by our Release Schedule.
Summary
It adds the object of shared client theme described here by Discord.
Yes AI has been used (partially)
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.