Native-speaker review of lectures/numpy_vs_numba_vs_jax.md — NumPy vs Numba vs JAX — for the French edition, by Emile.
How the round works. When you are ready for this lecture, Matt drafts it afresh from the current English with the current release of the translation engine and opens one pull request, which replaces the lecture's French on main. Review the whole lecture there, reading it in the preview: put a suggestion block on any line you would change, commit a larger change to the pull request's branch, or list your corrections, numbered, in a review comment, as in your earlier pull requests. When your review is complete, approve the pull request and mention @mmcky in the summary. Matt then applies your suggestions with you credited as co-author, updates the engine from your review before the next lecture is drafted, and merges the pull request, which closes this issue. How a review round works has the details. There is no deadline.
What matters most: meaning errors; terms that disagree with the French glossary or with your earlier rulings (listed on #82 under "What stays the same", and on #42); French that reads unnaturally (academic register); code comments and docstrings (the rule is on #88). Please skip the spacing before : ; ! ?, which is set automatically, and the translation: block at the top of the file. An error in the English goes upstream: open an issue in QuantEcon/lecture-python-programming, link it in a comment on the line, and leave the translation matching the English as it stands; your review goes ahead without waiting for the fix.
Done when
- Emile's review of this lecture is complete
- Matt has applied the review, updated the engine and merged the pull request, which closes this issue
Native-speaker review of
lectures/numpy_vs_numba_vs_jax.md— NumPy vs Numba vs JAX — for the French edition, by Emile.lectures/numpy_vs_numba_vs_jax.md· published pageHow the round works. When you are ready for this lecture, Matt drafts it afresh from the current English with the current release of the translation engine and opens one pull request, which replaces the lecture's French on
main. Review the whole lecture there, reading it in the preview: put a suggestion block on any line you would change, commit a larger change to the pull request's branch, or list your corrections, numbered, in a review comment, as in your earlier pull requests. When your review is complete, approve the pull request and mention @mmcky in the summary. Matt then applies your suggestions with you credited as co-author, updates the engine from your review before the next lecture is drafted, and merges the pull request, which closes this issue. How a review round works has the details. There is no deadline.What matters most: meaning errors; terms that disagree with the French glossary or with your earlier rulings (listed on #82 under "What stays the same", and on #42); French that reads unnaturally (academic register); code comments and docstrings (the rule is on #88). Please skip the spacing before
: ; ! ?, which is set automatically, and thetranslation:block at the top of the file. An error in the English goes upstream: open an issue in QuantEcon/lecture-python-programming, link it in a comment on the line, and leave the translation matching the English as it stands; your review goes ahead without waiting for the fix.Done when