Conversation
📖 Netlify Preview Ready!Preview URL: https://pr-84--verdant-toffee-3261a8.netlify.app Commit: 📚 Changed LecturesBuild Info
|
Collaborator
Author
|
Hey Matt, I have a quick question on convention. I've noticed the chapters aren't fully consistent about whether comments and docstrings inside code cells get translated into French. about_py.md already has French comments like # Charger la bibliothèque, but some other chapters leave comments and docstrings in English. Should we translate explanatory comments and docstrings consistently going forward, while leaving code identifiers, API names, and executable output strings as-is? Want to make sure I'm applying the same rule across chapters rather than deciding it one by one. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review of the French translation of About These Lectures
Relative Popularity section – the English insertion "one of the most -- if not the most --" doesn't translate naturally into French with this construction, since "l'un des langages les plus populaires" and "le langage le plus populaire" need different grammatical structures.
Python est l'un des -- si ce n'est le -- langages de programmation les plus populaires.Python est l'un des langages de programmation les plus populaires, si ce n'est le plus populaire.NumPy Alternatives section – the placement of
intégréswas ambiguous and could be read as modifying onlyopérations sur les tableauxrather than both array types and array operations.Des bibliothèques telles que JAX, PyTorch et CuPy disposent également de types de tableaux et d'opérations sur les tableaux intégrés qui peuvent être très rapides et efficaces.Des bibliothèques telles que JAX, PyTorch et CuPy intègrent également des types de tableaux et des opérations sur les tableaux qui peuvent être très rapides et efficaces.Graphics section – terminology consistency with the figure caption immediately below it (
Exemple de tracé de contour).des tracés, des histogrammes, des images de contours, des graphiques 3D, des diagrammes à barres, etc.des tracés, des histogrammes, des tracés de contours, des graphiques 3D, des diagrammes à barres, etc.Graphics section – capitalization of
Matplotlibfor consistency with the rest of the document.une interface de haut niveau pour matplotlibune interface de haut niveau pour Matplotlib