Skip to content

The #325 lighting tests no longer depend on the project's shadow settings (#325) - #363

Merged
LogicalError merged 1 commit into
mainfrom
fix-325-lighting-tests
Nov 19, 2026
Merged

LogicalError merged 1 commit into
mainfrom
fix-325-lighting-tests

Conversation

@LogicalError

Copy link
Copy Markdown
Member

What this changes and why

Two tests from #325 depended on more than their own setup:

  • APillarInARoom_ShadowsTheFloorFromALamp needed the project's render pipeline to let lights other than the main one cast shadows. In a project where they don't, the lamp casts no shadow and the test failed. It now turns that setting on for its run (URP's supportsAdditionalLightShadows, whose setter is internal) and puts it back afterwards; with a render pipeline that has no such setting it is skipped.
  • ABakedLamp_LightsARoomAsACarvedOne_AndAgainAfterAnEdit has been seen to find the floor black after a bake, rarely. Its message now says what the bake left: the lightmap's index and count, whether its texture and the lighting data are there.

Fixes #325

How it was tested (scene, steps, Unity version)

With the project's render pipeline not letting additional lights cast shadows, the pillar test failed (the floor 0.0792 with and without shadows) before the change and passes after it, in Unity 6.6 (6000.6.0f1) and Unity 7 (7000.0.0a12); the project's pipeline asset is unchanged afterwards. ChiselSubtractiveWorkflowTests: 80 passed in both.

  • Compiles without warnings, in the editor and in a player build
  • Tests added or updated, and the EditMode tests pass

APillarInARoom_ShadowsTheFloorFromALamp needed the project's render
pipeline to let lights other than the main one cast shadows, and failed in
a project where they don't. It now turns that on for its run and puts it
back; without such a setting in the render pipeline it is skipped.

When the baked lamp doesn't light the floor, the bake test's message says
what the bake left: the lightmap's index and count, whether its texture and
the lighting data are there.
@LogicalError
LogicalError merged commit 0a4b9cc into main Nov 19, 2026
5 checks passed
@LogicalError
LogicalError deleted the fix-325-lighting-tests branch November 19, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant