fix: Make zoom to fit plugin keyboard and screenreader accessible#2728
Open
gonfunko wants to merge 1 commit into
Open
fix: Make zoom to fit plugin keyboard and screenreader accessible#2728gonfunko wants to merge 1 commit into
gonfunko wants to merge 1 commit into
Conversation
mikeharv
approved these changes
Jun 24, 2026
mikeharv
left a comment
mikeharv
left a comment
Contributor
There was a problem hiding this comment.
Looks good. My questions do not block approval.
| Blockly.utils.aria.setState( | ||
| this.svgGroup, | ||
| Blockly.utils.aria.State.LABEL, | ||
| 'Zoom to fit', |
Contributor
Author
There was a problem hiding this comment.
Yes, but I think we're better doing a pass across all of samples since the translation situation overall is pretty poor. This will become much less painful once it's a monorepo as well.
| this.svgGroup, | ||
| ); | ||
|
|
||
| const image = Blockly.utils.dom.createSvgElement( |
Contributor
There was a problem hiding this comment.
Do we need to hide this element from the accessibility tree?
Contributor
Author
There was a problem hiding this comment.
Experimentally it seemed fine, the screenreader wasn't attempting to read it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR fixes #2712 by making the zoom to fit control keyboard navigable and screenreader accessible following a similar pattern to the built-in zoom controls. This depends on a new release of core that adds
Capability.FOCUSABLE. With these changes, the control can be tabbed to, enter/space will activate it, it has a screenreader label and role of button, and focusing it will draw a highlight ring and darken the icon in the same manner as hovering over it.