fix(field-bitmap): revert separate keys for revert and commit - #2760
Merged
Conversation
This was referenced Jul 28, 2026
lizschwab
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
This work is being duplicated in core at RaspberryPiFoundation/blockly#10205 due to RaspberryPiFoundation/blockly#10203.
The details
Proposed Changes
Removes the recently added private
onEditorKeyDownmethod fromFieldBitmapwhich handled committing updated field values or reverting to the initial value.This also unmarks
field-bitmapandfield-colour-hsv-slidersas private so that we can release 13.2.0 versions of each.Reason for Changes
Part of #2754 included a behavior change where pressing escape would revert to the initial field value. This aligns to other fields, but it was deemed too risky as it's worse to suddenly lose a bunch of pixel changes than it is to have to hit undo if you didn't mean to commit them.