Repository navigation
Conversation
@blockly/dev-scripts now accepts TypeScript 6 as a peer, and create-package pins new TypeScript plugins to ^6.0.3 instead of the latest release, since dev-scripts and ts-loader do not support TypeScript 7. Fixes RaspberryPiFoundation#10507
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #10507
Proposed Changes
@blockly/dev-scriptsaccepts TypeScript^4.3.2 || ^5 || ^6as a peer.@blockly/create-packagewritestypescript: ^6.0.3for new TypeScript plugins instead of the latest release.Reason for Changes
New TypeScript plugins got
typescript@^7.0.2, which failsnpm installagainst the dev-scripts peer range, and ts-loader doesn't support 7 yet. Every TypeScript plugin in this repo already builds on^6.0.3; the repo'slegacy-peer-deps=truehides the peer conflict here.Test Coverage
main, a generated plugin failsnpm installwith the ERESOLVE from the issue.npm run buildsucceeds.npm ci,npm run lint,npm run format-checkandnpm run buildpass at the root.Documentation
None needed.
Additional Information
I kept
^4.3.2in the peer range so it only widens. Happy to drop it if you'd rather go with^5 || ^6.The generator writes the latest published dev-scripts version, so new plugins only install cleanly once this dev-scripts change is released.
AI use: I used Claude Code to write the code changes and run the verification above.