Conversation
maribethb
reviewed
Apr 22, 2026
Contributor
maribethb
left a comment
maribethb
left a comment
There was a problem hiding this comment.
1 question about ephemeral focus, and then also want to double check there's no behavioral change for developers who are calling our prompt functions right? so this isn't breaking?
Contributor
Author
|
Correct, there should be no functional behavior difference - same API calls work, the contents are just displayed in our custom dialog vs the browser modal. And it's still possible for developers to replace our implementation with their own. |
maribethb
approved these changes
Apr 22, 2026
Contributor
Author
|
This also fixed #9106. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9122
Proposed Changes
This PR updates Blockly's
dialogutility to use a<dialog>element instead of the built-in browser alert modals. This allows for more consistent focus management, since the dialog is just part of the DOM rather than an application-level modal. Secondarily, it adds an event listener to the flyout workspace in the create variable button callback handler that identifies and focuses the newly-created variable block for convenience now that the flyout no longer closes.