Repository navigation
Remove creator_id - #1048
Open
cocomarine wants to merge 15 commits into
Open
Remove creator_id#1048cocomarine wants to merge 15 commits into
cocomarine wants to merge 15 commits into
Conversation
Test coverage93.84% line coverage reported by SimpleCov. |
raspberrypiherokubot
temporarily deployed
to
editor-api-p-1841-remov-w6vg1r
October 6, 2026 12:11
Inactive
…tion/editor-api into 1841-remove-creator-id
…al variable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…al variable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
What's changed?
creator_idcolumn from theSchoolmodelcurrent_user.idasowner_idtoSchool::Create, which passes it toSchoolOnboardingService#onboardto create the owner and teacher rolesSchool::Createtakes a Postgres advisory transaction lock keyed onowner_idbefore saving the schoolcreator_iduniqueness constraint prevented duplicates.School::Createruns in a savepoint (requires_new: true), so a failure rolls back the school even when called inside an outer transaction (e.g.SchoolImportJob)Rolevalidation failures during onboarding, for example when the user already has a role in a different school, are merged into the school's errors and returned as a failed response. They are not sent to Sentry. OtherRecordInvaliderrors are sent to Sentrycreator_idfrom the admin dashboardContactSyncJobtoRoleSyncJobfor the owner role