Use Mayer bond orders for the IRC endpoint check - #954
Open
kfir4444 wants to merge 1 commit into
Open
Conversation
This was referenced Aug 10, 2026
kfir4444
force-pushed
the
irc_bond_order_check
branch
from
August 10, 2026 09:09
4900bfc to
35a3621
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mol_from_dft #954 +/- ##
===============================================
Coverage ? 63.62%
===============================================
Files ? 114
Lines ? 38515
Branches ? 10074
===============================================
Hits ? 24507
Misses ? 11079
Partials ? 2929
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 4/5 — based on #953. This is the payoff of the stack.
What
check_irc_species_and_rxn()takes optionallog_path_1/log_path_2and prefers connectivity derived from the computed Mayer bond orders. The existing distance-based perception and the bond-list comparison remain as ordered fallbacks.No new plumbing was needed in the scheduler:
check_irc_species()already passesoutput[label]['paths']['geo'], which is the path to the log file of the IRC endpoint's re-optimization job.Why it matters — measured, not asserted
For a real isoxazole → 2H-azirine ring opening, with both endpoints optimized in Orca and both logs added as fixtures:
FalseTrueThe distance heuristic mis-perceives the strained three-membered ring of the product, so a correct TS would have been rejected. Both verdicts are pinned as assertions in the test, so the contrast is a regression guard rather than a claim in a description.
Behaviour when bond orders are unavailable
Unchanged. Older logs, an ESS that does not report a Mayer analysis, a
Nonepath or a nonexistent file all fall through to exactly today's code path. The existingtest_check_irc_species_and_rxnpasses untouched.Why the endpoints' opt logs and not the IRC logs
Gaussian prints the Mayer block at the final population analysis, so an
optlog has it for the converged geometry while anirclog may not have it per point. ARC already re-optimizes both IRC endpoints asIRC_<label>_1/2species inspawn_post_irc_jobs(), so those logs are the natural source and are already tracked.Conflict note
#937 and #938 also touch
arc/checks/ts.pyandarc/checks/ts_test.pyaround the IRC check. Whichever lands first, this will need a rebase — the changes are adjacent rather than contradictory.Testing
pytest arc/checks/— 50 passed, 2 failed. Both failures are the pre-existingtest_check_rxn_e0/test_compute_rxn_e0, which fail identically onmain(Arkane cannot importpybelinrmg_envhere).🤖 Generated with Claude Code