Skip to content

4.x: Cleanup + lambda instead of inner class check#8179

Merged
akarnokd merged 3 commits into
ReactiveX:4.xfrom
akarnokd:4xVerifyLambdaUsageTest
Jun 25, 2026
Merged

4.x: Cleanup + lambda instead of inner class check#8179
akarnokd merged 3 commits into
ReactiveX:4.xfrom
akarnokd:4xVerifyLambdaUsageTest

Conversation

@akarnokd

Copy link
Copy Markdown
Member

Runs the following regex against all java files to detect anonymous inner class creation:

new\s+\w+(?:\s*<(?:[\s\w<>(\[\])?,.?]|\s*<[\s\w<>(\[\])?,.?]*>)*>)?\s*\([^)]*\)\s*\{

It will have all the file and line numbers in the crash exception.

If an anonymous inner class has state, use the /* NFI */ comment between the ) and {:

- new SomeClass() {
+ new SomeClass() /* NFI */ {

@akarnokd akarnokd added this to the 4.0 milestone Jun 25, 2026
@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.427 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/test/java/io/reactivex/rxjava4/internal/operators/observable/BlockingObservableNextTest.java: 4.512
src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerConcurrencyTests.java: 4.090
src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerTests.java: 4.480
src/test/java/io/reactivex/rxjava4/schedulers/TestSchedulerTest.java: 4.627

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.427 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/test/java/io/reactivex/rxjava4/internal/operators/observable/BlockingObservableNextTest.java: 4.512
src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerConcurrencyTests.java: 4.090
src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerTests.java: 4.480
src/test/java/io/reactivex/rxjava4/schedulers/TestSchedulerTest.java: 4.627

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.427 bits/char
Verdict: ✅ Mid-4 beauty detected (thoughtful human code!)

Changed files entropy:

src/test/java/io/reactivex/rxjava4/internal/operators/observable/BlockingObservableNextTest.java: 4.512
src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerConcurrencyTests.java: 4.090
src/test/java/io/reactivex/rxjava4/schedulers/AbstractSchedulerTests.java: 4.480
src/test/java/io/reactivex/rxjava4/schedulers/TestSchedulerTest.java: 4.627

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.33%. Comparing base (972ba74) to head (d58230c).

Additional details and impacted files
@@            Coverage Diff            @@
##                4.x    #8179   +/-   ##
=========================================
  Coverage     98.33%   98.33%           
- Complexity     6937     6939    +2     
=========================================
  Files           785      785           
  Lines         49015    49015           
  Branches       6603     6603           
=========================================
+ Hits          48200    48201    +1     
+ Misses          625      620    -5     
- Partials        190      194    +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akarnokd akarnokd merged commit 4d304b9 into ReactiveX:4.x Jun 25, 2026
6 checks passed
@akarnokd akarnokd deleted the 4xVerifyLambdaUsageTest branch June 25, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant