Add ExportOutput read action#261
Open
davidwzhao wants to merge 8 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
comnik
reviewed
Jun 19, 2026
Comment on lines
+179
to
+191
| message ExportCSVOutput { | ||
| ExportCSVSource csv_source = 1; | ||
| CSVConfig csv_config = 2; | ||
| } | ||
|
|
||
| message ExportOutput { | ||
| string name = 1; | ||
|
|
||
| // Supports export formats e.g., CSV and Iceberg, but considered to be part of txn results | ||
| oneof export_output { | ||
| ExportCSVOutput csv = 2; | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Could we not just reuse ExportCSVConfig instead of introducing ExportCSVOutput?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
ExportOutput, which is kinda halfway in betweenExportandOutput. Currently, onlyExportCSVOutputis supported, which indicates that results should be written in CSV format (similar toExport). However, the action does not specify a path, and instead it's treated as a transaction output by the engine, and written to whatever path the engine deems appropriate (similar toOutput).