Repository navigation
fix: handle null responses from first siging credential store registered - #173
Merged
patchandthat merged 3 commits intoNov 10, 2026
Merged
Conversation
jhbritton-RSK
force-pushed
the
bug/empty-first-siginingcredential-store-error
branch
from
November 10, 2026 12:07
026e8df to
6d163ac
Compare
patchandthat
approved these changes
Nov 10, 2026
patchandthat
approved these changes
Nov 10, 2026
patchandthat
deleted the
bug/empty-first-siginingcredential-store-error
branch
November 10, 2026 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When registering signing credential stores, if the first registered one returns null, null is returned by the DefaultKeyMaterialService.GetSigningCredentialsAsync(null) method is called without specifying allowed algorithms.
A fix was added to iterate over each store until a non-null value is returned, or throw an exception if all return null.
Edit: updated documentation around compatibility key store
Type of change
Does this PR introduce a breaking change?
n/a
Testing
Unit tested added for key material service
LLM Usage
Asked an LLM to review the changed files for any issues.
Other context
n/a