fix No OpEntryPoint for non-public entry points#565
fix No OpEntryPoint for non-public entry points#56539ali wants to merge 1 commit intoRust-GPU:mainfrom
Conversation
|
Ohhh, that is a good idea! I was be concerned about automatic @Firestar99 do you see any potential issues I am missing? |
Firestar99
left a comment
There was a problem hiding this comment.
It is an improvement, but doesn't solve it for the following code:
mod private {
#[spirv(fragment)]
pub fn main() {}
}I think we can merge this anyway, but do note that when I do get back to the asm!-based entry point system the next weeks, it shouldn't suffer from this problem at all, since global_asm! is always accessible (doesn't need to be "monomorphized" by being pub and accessible from potentially external crates).
|
@Firestar99 we can |
|
Thank you for the PR! 🍻 |
fixes the confusing
No OpEntryPoint instruction was foundyou get when entry point is private#293