Skip to content

reopened forked PRs should fetch results from fork repo checks#2295

Merged
raeessap merged 1 commit into
sapmachinefrom
colab_reopen_pr
Jun 24, 2026
Merged

reopened forked PRs should fetch results from fork repo checks#2295
raeessap merged 1 commit into
sapmachinefrom
colab_reopen_pr

Conversation

@raeessap

@raeessap raeessap commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

it happened that when a user close the forked PR and then reopen the same PR, the PR did not showed sanity checks results from forked repo. with this PR, this problem is solved.

  • First lookup (SHA): correct, precise match for opened / synchronize.
  • Fallback (branch + PR number): safety net for reopened, where no new SHA run exists.
  • HEAD_SHA env var: required regardless, because check-run creation depends on it.

fixes #1985

@SapMachine

Copy link
Copy Markdown
Member

Hello @raeessap, this pull request fulfills all formal requirements.

@raeessap raeessap requested a review from RealCLanger June 24, 2026 12:27
@raeessap

raeessap commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

this PR is well tested on raeesorg#2

@raeessap raeessap merged commit 214f443 into sapmachine Jun 24, 2026
106 of 109 checks passed
@raeessap raeessap deleted the colab_reopen_pr branch June 24, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Github Actions settings for new SapMachine branches

4 participants