chore: add CI check to enforce version bump when src/ is modified - #79
Merged
Merged
Conversation
jplbrun
marked this pull request as ready for review
April 24, 2026 12:50
jeanscherf
approved these changes
Apr 24, 2026
jeanscherf
left a comment
jeanscherf
left a comment
Member
There was a problem hiding this comment.
Great work on this, @jplbrun Very clean implementation. This is exactly what we needed.
Two small things I wanted to comment:
- When src/ is not modified, the job exits silently with no output.
Maybe an extra else withecho "No src/ changes. Version bump not required."would make the CI logs self-explanatory. - The file is named .yml while all other workflows in this repo use .yaml. Maybe it's worth aligning for consistency.
Neither is a blocker. Thanks for picking this up!
soumyadey
added a commit
to soumyadey/cloud-sdk-python
that referenced
this pull request
Oct 3, 2026
Redesign the CBC client around a generic core and a platform adapter layered strictly on top of it. Core (client.py): base_url and app_tenant_id are per-request callables; the only credential input is an ssl.SSLContext. create_client is a thin factory. Drops TenantContext, config.py, _http.py, and all env/cert-file machinery. Platform adapter (client_adapter.py): ships the SAP application-platform provisioning defaults. The SDK owns two ContextVars (app_tenant_id_var, tenant_subdomain_var) that the app populates; create_agent_client resolves base_url from the tenant-mapping Destination Fragment (listing the subaccount and matching on appTenantId, pre-PR-SAP#79 shape) and loads the provider mTLS cert from the Destination Service. Every default is overridable via args or CLOUD_SDK_CBC_* env vars. CBC unit coverage 98% (adapter 100%).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a GitHub Actions workflow that fails the PR if any file under src/ was changed but the version = "..." line in pyproject.toml was not modified