Feature/gp plane crossers#5
Open
mvicenzi wants to merge 5 commits into
Open
Conversation
…irection in 3D space.
Version v10_06_00_05, patch for SBN2025A
PetrilloAtWork
approved these changes
Feb 9, 2026
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
Member
There was a problem hiding this comment.
Disclaimer: I am the author of this code.
Contributor
|
@leoaliaga could you run the CI on this please against the SBN_SUITE at HEAD of release/SBN2025A? Thanks! |
4 tasks
There was a problem hiding this comment.
Pull request overview
This PR adds a new header-only utility algorithm, util::PlaneCrossers, to compute the intersection between a plane (defined by two spanning axes) and a straight line, and wires it into the build/test system with a new Boost unit test.
Changes:
- Introduce
sbnalg/Utilities/PlaneCrossers.himplementing plane/line intersection via Cramer’s rule (3D). - Add a new Boost unit test
test/Utilities/PlaneCrossers_test.cxxand register it with CMake. - Add new
Utilities/subdirectories to both the library and test CMake trees.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
sbnalg/Utilities/PlaneCrossers.h |
Adds the util::PlaneCrossers template and its inline implementation. |
sbnalg/Utilities/CMakeLists.txt |
Creates the (header-only) Utilities library target and installs headers/sources. |
sbnalg/CMakeLists.txt |
Adds the new Utilities subdirectory to the build. |
test/Utilities/PlaneCrossers_test.cxx |
Adds a Boost unit test and a documentation example test for PlaneCrossers. |
test/Utilities/CMakeLists.txt |
Registers the new PlaneCrossers_test with CTest/Boost. |
test/CMakeLists.txt |
Adds the new Utilities test subdirectory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
util::PlaneCrossersalgorithm for plane/line intersection.This is used by the new "cathode crossers" event generator in
icaruscode.This PR is required by: