Skip to content

Resolve starlette deprecation warnings in test outputs - #5967

Open
davem-bis wants to merge 4 commits into
SQLMesh:mainfrom
davem-bis:feature/DRM/resolve-starlette-deprecation-warnings
Open

Resolve starlette deprecation warnings in test outputs#5967
davem-bis wants to merge 4 commits into
SQLMesh:mainfrom
davem-bis:feature/DRM/resolve-starlette-deprecation-warnings

Conversation

@davem-bis

@davem-bis davem-bis commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Description

I have:

  • Changed the webserver exception type of HTTP_422_UNPROCESSABLE_ENTITY to HTTP_422_UNPROCESSABLE_CONTENT.
  • Changed the httpx dev requirement to httpx2, as the use of httpx with starlette.testclient is deprecated.

Test Plan

  • For the change to 422 HTTP responses, these are covered by tests in tests/web/test_main.py (including but not limited to; test_rename_file_to_existing_directory, test_create_directory_already_exists, test_rename_directory_already_exists_not_empty)
  • For the change of httpx to httpx2, this package is only used in the test tests/web/test_main.py::test_cancel, which still passes.

Checklist

  • I have run make style and fixed any issues
  • I have added tests for my changes (if applicable)
  • All existing tests pass (make fast-test)
  • My commits are signed off (git commit -s) per the DCO

Signed-off-by: davem-bis <68955845+davem-bis@users.noreply.github.com>
…letteDeprecationWarning: Using `httpx` with `starlette.testclient` is deprecated; install `httpx2` instead."

Signed-off-by: davem-bis <68955845+davem-bis@users.noreply.github.com>
@davem-bis davem-bis changed the title Feature/drm/resolve starlette deprecation warnings Resolve starlette deprecation warnings in test outputs Aug 21, 2026
@davem-bis
davem-bis marked this pull request as ready for review August 21, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant