memory_profiler reporting itself #49

Activity

1. dgynn commented on Sep 25, 2017

   

   dgynn

   on Sep 25, 2017

   Collaborator

   More actions

   I think you may have mixed the .start/.stop mode with the .report mode in your IRB session.

   I can recreate memory_profiler self-reporting by calling MemoryProfiler.start first. I expect that your IRB session got into a weird state this way.

   MemoryProfiler.start
   MemoryProfiler.report { "allocate one string" }.pretty_print
   
   Total allocated: 1496 bytes (10 objects)
   Total retained:  232 bytes (1 objects)
   
   allocated memory by gem
   -----------------------------------
         1456  memory_profiler/lib
           40  other
   ...
   

   Please re-open this issue if can recreate the problem in a clean IRB session or a script.
2. dgynn

   closed this as completedon Sep 25, 2017
3. seanlinsley commented on Sep 25, 2017

   

   seanlinsley

   on Sep 25, 2017

   More actions

   BTW @dgynn unless GitHub has changed how it works, issue creators can't re-open issues that a contributor has closed.
4. dgynn commented on Sep 25, 2017

   

   dgynn

   on Sep 25, 2017

   Collaborator

   More actions

   Thanks @seanlinsley I didn't realize that.
5. aiman2039 commented on Sep 25, 2017

   

   aiman2039

   on Sep 25, 2017

   Last edited by aiman2039

   Author

   More actions

   @dgynn it's a 100% not due to me calling MemoryProfiler.start since I never use that and always opt for :

   report = MemoryProfiler.report do
   ......
     end 
     report.pretty_print( to_file: 'file.txt' )
   

   But it's a little spurious , I'll try creating a more consistent testcase.
6. dgynn commented on Sep 25, 2017

   

   dgynn

   on Sep 25, 2017

   Collaborator

   More actions

   @ohaddahan Oh, here's a possible cause. If the block of code being reported on throws an exception we are not cleaning up correctly.

   MemoryProfiler.report { raise "error" } rescue nil
   MemoryProfiler.report { "allocate one string" }.pretty_print
   
   Total allocated: 1496 bytes (10 objects)
   Total retained:  232 bytes (1 objects)
   
   allocated memory by gem
   -----------------------------------
         1456  memory_profiler/lib
           40  other
   

   Is it possible that happened in your IRB session? That is something we should handle better.
7. dgynn

   reopened this on Sep 25, 2017
8. aiman2039 commented on Sep 25, 2017

   

   aiman2039

   on Sep 25, 2017

   Author

   More actions

   @dgynn might be it , I'll give a try. Sounds possible since ctrl+C is quite common during interactive debug session :)