Update dsr1-fp8-mi300x-sglang SGLang image to v0.5.12-rocm700-mi30x#1425
Update dsr1-fp8-mi300x-sglang SGLang image to v0.5.12-rocm700-mi30x#1425Klaud-Cold wants to merge 1 commit into
Conversation
Ref #1154 Co-authored-by: Klaud Cold <Klaud-Cold@users.noreply.github.com>
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. |
| - dsr1-fp8-mi300x-sglang | ||
| description: | ||
| - "Update SGLang image from v0.5.9-rocm700-mi30x to v0.5.12-rocm700-mi30x" | ||
| pr-link: XXX |
There was a problem hiding this comment.
🔴 The new perf-changelog.yaml entry for dsr1-fp8-mi300x-sglang has pr-link: XXX instead of the actual PR URL. Every other entry in this file uses the canonical form https://github.com/SemiAnalysisAI/InferenceX/pull/<num>, so this looks like a forgotten template substitution — it should be https://github.com/SemiAnalysisAI/InferenceX/pull/1425. Any tooling that parses pr-link as a URL or extracts the PR number for cross-referencing will break on this entry.
Extended reasoning...
What the bug is
The new entry added at the bottom of perf-changelog.yaml (lines 2551–2556) ends with:
- config-keys:
- dsr1-fp8-mi300x-sglang
description:
- "Update SGLang image from v0.5.9-rocm700-mi30x to v0.5.12-rocm700-mi30x"
pr-link: XXXThe literal string XXX is an unsubstituted template placeholder — it is not a valid URL.
Why this is clearly a bug (not intentional)
Looking at every other entry in the same file, the pr-link field always holds a full GitHub PR URL. The five immediately preceding entries (lines 2526, 2532, 2538, 2544, 2550) all use the canonical form:
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/<num>
For example, line 2550 (the entry just above the new one) uses https://github.com/SemiAnalysisAI/InferenceX/pull/1402. The new entry is the only one in the file with a non-URL value, which strongly indicates a forgotten substitution rather than a deliberate convention.
Step-by-step proof
- The PR is Update dsr1-fp8-mi300x-sglang SGLang image to v0.5.12-rocm700-mi30x #1425 ("Update dsr1-fp8-mi300x-sglang SGLang image to v0.5.12-rocm700-mi30x").
- The diff adds exactly two changes: the image bump in
.github/configs/amd-master.yamland a corresponding changelog entry inperf-changelog.yaml. - The new changelog entry ends with
pr-link: XXX. - By the existing file convention (verified at lines 2526, 2532, 2538, 2544, 2550), this field is always a full PR URL.
- The correct value, given this is PR Update dsr1-fp8-mi300x-sglang SGLang image to v0.5.12-rocm700-mi30x #1425, would be
https://github.com/SemiAnalysisAI/InferenceX/pull/1425.
Impact
This does not affect runtime/benchmark behavior — the image bump itself is correct. However:
- Any downstream tooling that walks
perf-changelog.yamland parsespr-linkas a URL (e.g. for rendering links in a changelog UI, validating links, or extracting the PR number for cross-referencing) will fail or skip this entry. - It also breaks the documented/observed format of the changelog file, hurting consistency and reviewer trust.
How to fix
Replace line 2556 with:
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1425|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=25980020879 |
Updates SGLang image for
dsr1-fp8-mi300x-sglangfrom v0.5.9-rocm700-mi30x to v0.5.12-rocm700-mi30x.\nRef #1154
Generated with Claude Code