Skip to content

[Klaud Cold] Update minimaxm2.5-fp4-b300-vllm vLLM image to v0.21.0 #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
functionstackx merged 3 commits into from
May 18, 2026
Merged

[Klaud Cold] Update minimaxm2.5-fp4-b300-vllm vLLM image to v0.21.0 #1453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e635b5
Update minimaxm2.5-fp4-b300-vllm vLLM image to v0.21.0
functionstackx May 17, 2026
ff2e62f
chore: fill pr-link for #1453
functionstackx May 17, 2026
c4429f1
Merge branch 'main' into update-minimaxm2.5-fp4-b300-vllm-v0.21.0
functionstackx May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/configs/nvidia-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4427,7 +4427,7 @@ minimaxm2.5-fp4-b200-vllm-agentic:
# MiniMax-M2.5 FP4 B200 vLLM recipe as-is until B300-specific tuning is available.

minimaxm2.5-fp4-b300-vllm:
image: vllm/vllm-openai:v0.19.0-cu130
image: vllm/vllm-openai:v0.21.0
model: nvidia/MiniMax-M2.5-NVFP4
model-prefix: minimaxm2.5
runner: b300
Expand Down
6 changes: 6 additions & 0 deletions perf-changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2808,3 +2808,9 @@
description:
- "Update vLLM image from v0.20.0-cu130 (18d old) to v0.21.0"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1456

- config-keys:
- minimaxm2.5-fp4-b300-vllm
description:
- "Update vLLM image from v0.19.0-cu130 (26d old) to v0.21.0"
pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1453
Comment on lines +2812 to +2816
Copy link
Copy Markdown
Contributor

@claude claude Bot May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The new perf-changelog entry's description contains an automation-metadata annotation "(26d old)" that does not appear in any other entry in this file. All ~50+ other "Update image from to " entries follow the strict format without an age suffix; consider stripping the parenthetical so this line reads "Update vLLM image from v0.19.0-cu130 to v0.21.0" for consistency.

Extended reasoning...

What the bug is

The new entry added to perf-changelog.yaml (line 2636) reads:

- config-keys:
    - minimaxm2.5-fp4-b300-vllm
  description:
    - "Update vLLM image from v0.19.0-cu130 (26d old) to v0.21.0"
  pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1453

The parenthetical (26d old) is a freshness/age annotation produced by the automation that opened this PR — the same string appears verbatim in the PR description ("Bumps minimaxm2.5-fp4-b300-vllm from vllm/vllm-openai:v0.19.0-cu130 (26d old) to vllm/vllm-openai:v0.21.0"). It is automation metadata that escaped into the human-readable, version-controlled changelog.

Why this is inconsistent with the rest of the file

perf-changelog.yaml has a strong convention: every "Update …" description follows the shape Update <framework> image from <oldver> to <newver> with no annotations. A grep for \(\d+d old\) across the entire file returns exactly one match — this new entry. Concrete comparison with the immediately preceding analogous entries:

  • Line 2605: Update SGLang image from v0.5.11-cu130 to v0.5.12-cu130
  • Line 2611: Update SGLang image from v0.5.10-rocm720-mi30x to v0.5.12-rocm720-mi30x
  • Line 2618: Update SGLang image from v0.5.11-cu130 to v0.5.12-cu130
  • Line 2624: Update vLLM image from v0.15.1 to v0.20.2
  • Line 2630: Update vLLM ROCm image from v0.18.0 to v0.21.0

None of these carry an age suffix.

Step-by-step proof

  1. Open perf-changelog.yaml and grep for Update vLLM image from — 19 matches across recent history.
  2. Of those 19, 18 follow the form Update vLLM image from <oldver> to <newver> with no parenthetical.
  3. Exactly one — the new entry at line 2636, added by this PR — contains (26d old).
  4. Cross-reference the PR description: the same (26d old) substring appears there, confirming it is automation freshness metadata copied verbatim rather than intentional changelog prose.

Impact

Purely cosmetic. The file is YAML and the field is a free-text description, so this does not affect parsing, runtime, CI, or any downstream tooling I'm aware of. The only cost is a small inconsistency in a changelog that is otherwise uniformly formatted.

Suggested fix

Strip the parenthetical so the description reads:

description:
  - "Update vLLM image from v0.19.0-cu130 to v0.21.0"

Going forward, the automation that generates these changelog entries should strip the (Nd old) suffix before emitting the description string.

Loading