[AMD] Update qwen3.5-fp4-mi355x-sglang-agentic-mtp SGLang ROCm image to v0.5.19-rocm720-mi35x-20260908 / 升级 qwen3.5-fp4-mi355x-sglang-agentic-mtp 的 SGLang ROCm 镜像至 v0.5.19-rocm720-mi35x-20260908 - #2904
Conversation
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献！请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md，然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人，你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板，包括保留英文语句 如需进行 PR 验证，请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动（flake），重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
2386702 to
416ecee
Compare
yichiche
changed the title
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34296161968 |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Reviewed this PR and didn't find any bugs beyond the pr-link placeholder already flagged in the inline findings. Also checked that the qwen3.5-fp4-mi355x-sglang-agentic-mtp recipe is single-node (multinode: false, no model.container field), so the multi-node image/container-sync invariant in AGENTS.md doesn't apply here.
Extended reasoning...
Verified via git diff that the change is exactly as described: a single image: tag bump in configs/amd-master.yaml for the qwen3.5-fp4-mi355x-sglang-agentic-mtp recipe, plus a new perf-changelog.yaml entry appended at the tail with no pre-existing bytes touched. Confirmed the recipe block has multinode: false and no model.container field, so the "image bumps require model.container to match" rule does not apply to this recipe. The pr-link: PRLINK_PLACEHOLDER issue is already surfaced as inline findings from the bug hunter (and matches the same pattern shown in CONTRIBUTING.md's own example, pull/XXX, suggesting this placeholder is expected to be filled in once the PR exists), so no need to restate it in the body. No other concerns found in the diff itself.
This review covers commit e15fc79, which is no longer the latest commit on this pull request; later commits are not covered by it.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34296234496 |
…to v0.5.19-rocm720-mi35x-20260908 将 qwen3.5-fp4-mi355x-sglang-agentic-mtp 配方的 SGLang ROCm 镜像升级到 v0.5.19-rocm720-mi35x-20260908。 Co-Authored-By: ChangLiu0709 <190883410+ChangLiu0709@users.noreply.github.com>
yichiche
changed the title
416ecee to
a76a943
Compare
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34299062702 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34296234496 |
1 participant
Summary / 摘要
Update the SGLang ROCm image for the Qwen3.5 MXFP4 MI355X AgentX recipe from
lmsysorg/sglang-rocm:v0.5.18-rocm720-mi35x-20260829tolmsysorg/sglang-rocm:v0.5.19-rocm720-mi35x-20260908.将 Qwen3.5 MXFP4 MI355X AgentX 配方使用的 SGLang ROCm 镜像从
lmsysorg/sglang-rocm:v0.5.18-rocm720-mi35x-20260829升级到lmsysorg/sglang-rocm:v0.5.19-rocm720-mi35x-20260908。Recipes touched / 涉及的配方:
qwen3.5-fp4-mi355x-sglang-agentic-mtpThe target tag was verified to exist on Docker Hub under
lmsysorg/sglang-rocm(HTTP 200). Note that the ROCm-suffixed tag does not exist underlmsysorg/sglang.目标镜像标签已确认存在于 Docker Hub 的
lmsysorg/sglang-rocm仓库（HTTP 200）。请注意，该 ROCm 后缀标签在lmsysorg/sglang仓库下并不存在。Test plan / 测试计划
full-sweep-fail-fastsweep passes. /full-sweep-fail-fast全量 sweep 通过。