add schema drift ci check#230
Open
kiftio wants to merge 2 commits into
Open
Conversation
React Native — Coverage Report
|
Web — Coverage Report
|
kiftio
force-pushed
the
schema-drift-check
branch
from
1b6d4b1 to
f5fb71b
Compare
kiftio
force-pushed
the
clean-quicktype-model-names
branch
from
d82df96 to
6f0c157
Compare
kiftio
force-pushed
the
schema-drift-check
branch
2 times, most recently
from
98beba8 to
9092fbd
Compare
markmur
reviewed
Jun 2, 2026
kiftio
force-pushed
the
schema-drift-check
branch
from
9092fbd to
6f0166e
Compare
kiftio
force-pushed
the
schema-drift-check
branch
from
6f0166e to
fffbe61
Compare
kiftio
commented
Jun 2, 2026
| await run("node", [path.join(PROTOCOL_DIR, "scripts", "generate_typescript_notifications.mjs")]); | ||
|
|
||
| const declarationOutput = path.join(PROTOCOL_DIR, "languages", "typescript", "src", "index.d.ts"); | ||
| const tscBin = path.join(REPO_ROOT, "platforms", "react-native", "node_modules", "typescript", "bin", "tsc"); |
Contributor
Author
There was a problem hiding this comment.
think we should be using protocol rather than react-native
kiftio
commented
Jun 2, 2026
| "devDependencies": { | ||
| "quicktype": "23.2.6" | ||
| "quicktype": "23.2.6", | ||
| "typescript": "5.9.2" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Adds a CI check that regenerates protocol models and fails if the committed generated files are stale or unexpected.
Scenarios:
The
Protocol Codegen Driftworkflow:ci.ymlnow runs this workflow when protocol files, the workflow, setup action, or the RN package/lockfile change.Why
Protocol schema changes can require regenerated SDK models across platforms. This check catches schema/codegen drift in CI instead of relying on reviewers or local regeneration.
Notes
quicktypeas a pinned React Native dev dependency so CI can run the existing generator.protocol/scripts/generate_models.shor generation behavior.How to test
n/a
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.