Open
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 72 files 502 suites 0s ⏱️ Results for commit 24f06e8. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 24f06e8 |
ctowns
approved these changes
Apr 14, 2026
tpmanley
reviewed
Apr 14, 2026
| vendorId: 0x1396 | ||
| productId: 0x1001 | ||
| deviceProfileName: light-color-level-fan | ||
| deviceProfileName: fan-modular |
Contributor
There was a problem hiding this comment.
fan-modular doesn't have all the capabilities that light-color-level-fan has
Contributor
Author
There was a problem hiding this comment.
That's true- it has all the fan related capabilities though, and the light capabilities will be included as a child device. This work was completed in this PR after some discussion a few months ago.
hcarter-775
force-pushed
the
update/orein-fingerprint
branch
from
33d3ae7 to
24f06e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Update the device fingerprint to use the latest device handling, introduced here. Add a comment to deprecate this profile, since it no longer is required.
Summary of Completed Tests