Aligned handlers and fields in value magnitude and added tests#3111
Merged
Conversation
|
Channel deleted. |
Test Results 73 files ± 0 536 suites - 2 0s ⏱️ ±0s Results for commit e566c1b. ± Comparison against base commit 4a06ba8. This pull request removes 2 and adds 13 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against e566c1b |
aleclorimer
force-pushed
the
zb-thermostat-zenwithin-overflow-fix
branch
from
July 9, 2026 16:34
e2b0384 to
08a32b8
Compare
varzac
reviewed
Jul 9, 2026
| local setpoint_limit_handler = function(limit_type) | ||
| return function(driver, device, limit) | ||
| device:set_field(limit_type, limit.value, {persist = true}) | ||
| device:set_field(limit_type, limit.value / 100.0, {persist = true}) |
Contributor
There was a problem hiding this comment.
While this will fix it for future devices, this value is already persisted on existing devices, so even though I think this change makes more sense in a vacuum, for this fix, I think we need to keep persisting in centidegrees (and comment that we are doing such) and then do this division on the checks. We'll have to update the DEFAULT values as well
aleclorimer
force-pushed
the
zb-thermostat-zenwithin-overflow-fix
branch
2 times, most recently
from
July 9, 2026 20:22
aeac47a to
4254ba3
Compare
varzac
reviewed
Jul 10, 2026
varzac
reviewed
Jul 10, 2026
aleclorimer
force-pushed
the
zb-thermostat-zenwithin-overflow-fix
branch
2 times, most recently
from
July 14, 2026 18:06
55f504a to
2376ac9
Compare
aleclorimer
force-pushed
the
zb-thermostat-zenwithin-overflow-fix
branch
from
July 16, 2026 20:34
2376ac9 to
d8fc967
Compare
cjswedes
approved these changes
Jul 20, 2026
| ) | ||
|
|
||
| test.register_message_test( | ||
| "MinHeatSetpointLimit report stores device field", |
Contributor
There was a problem hiding this comment.
What is actually being tested here? Maybe needs to be a coroutine test to check device fields with get_field
Contributor
Author
There was a problem hiding this comment.
That the fields were actually being handled. I verified that it breaks the tests if the handlers are not set, but you're right. I should just check those values for more sanity while im at it. Updated
varzac
approved these changes
Jul 21, 2026
cjswedes
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where
(min|max)(Heat|Cool)SetPointwas being set in centidegrees and then being used to clamp a value in degrees causing the clamped value to have an Int16 overflow error when then tried to scale to centidegrees.Mutant testing: Failing without the
/ 100.0fix/update.