Repository navigation
refactored solid-pane navigation - #471
Merged
Merged
Conversation
…istry@5.0.2-0) (latest: rdflib@2.4.1 solid-ui@5.0.1 solid-panes@5.0.0)
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The pinned solid-panes version does not export the newly called API.
1 open finding
What changed in this PR
Prevents duplicate rendering during browser back/forward navigation.
Changes:
- Skips the legacy
popstatehandler when solid-panes handles navigation.
| File | Description |
|---|---|
src/index.ts |
Guards legacy browser navigation handling. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // so this handler must not render a second time. The check is made when the event fires: this | ||
| // handler is registered at load, before the main page starts. | ||
| window.onpopstate = function (_event: any) { | ||
| if (panes.isHandlingBrowserNavigation()) return |
SharonStrats
approved these changes
Oct 14, 2026
…istry@5.0.2-0 solid-panes@5.1.0-0) (latest: rdflib@2.4.1 solid-ui@5.0.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.