Skip to content

CI tweaks + prerelease 3.1.3-3#812

Open
NoelDeMartin wants to merge 5 commits into
stagingfrom
ci
Open

CI tweaks + prerelease 3.1.3-3#812
NoelDeMartin wants to merge 5 commits into
stagingfrom
ci

Conversation

@NoelDeMartin

Copy link
Copy Markdown
Member

No description provided.

- Remove legacy component exports
- Declare peerDependencies
Comment thread package.json
"./components/media/photo-capture": {
"types": "./dist/components/photo-capture/index.d.ts",
"import": "./dist/components/photo-capture/index.esm.js",
"require": "./dist/components/photo-capture/index.cjs.js"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example of losing compatibility. Here with current dev mashlib package.
This was introduced to remove mashlib build errors in the UVDSL test.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but the correct fix here would be to remove the legacy imports from any pane that is still using them, rather than adding them back.

@bourgeoa

bourgeoa commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

3.1.3-3 was already published in #811
The current workflow shows guarding for staging branch as expected.

Run # Skip publishing when PR originates from staging (will publish after merge)

commit a new version to see it published with a dev tag after merging

@NoelDeMartin

Copy link
Copy Markdown
Member Author

The current workflow shows guarding for staging branch as expected.

I'm not sure it's fixed, because I'm pretty sure I opened the previous PR after the fix.

Looking at the code, I see you're comparing with github.base_ref. That is the target branch in a PR, that's why it's still being released on the PR (before merge). If you want to do it after merge, you should compare with github.ref. That will run it for every new commit in staging, regardless if it comes from a PR or a direct commit (which we should never do!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants