Repository navigation
Add num_chunk_per_batch to job kwargs and use it for zarr v3 shard writes - #4833
Open
samuelgarcia wants to merge 10 commits into
Open
samuelgarcia wants to merge 10 commits into
samuelgarcia wants to merge 10 commits into
Conversation
alejoe91
changed the title
num_chunk_per_batch ro job kwargs (for the zarr v3 shards)
alejoe91
changed the title
num_chunk_per_batch ro job kwargs (for the zarr v3 shards)num_chunk_per_batch to job kwargs (for the zarr v3 shards)
alejoe91
marked this pull request as draft
October 12, 2026 15:21
This was referenced Oct 13, 2026
alejoe91
marked this pull request as ready for review
October 30, 2026 10:40
Member
|
@samuelgarcia @h-mayorquin the last commit adds some core tests and sets |
alejoe91
changed the title
num_chunk_per_batch to job kwargs (for the zarr v3 shards)num_chunk_per_batch to job kwargs and use it for zarr v3 shard writes
Member
|
Hi guys, this is ready to review on my end @samuelgarcia @chrishalcrow @h-mayorquin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4831
Totally untested just a draft proof of concept.
@chrishalcrow
@h-mayorquin