build: add conflict with twig/twig 3.29.0 - #383
Merged
Merged
Conversation
stlgaits
marked this pull request as ready for review
September 21, 2026 09:43
stlgaits
changed the title
stlgaits
force-pushed
the
twig-conflict
branch
from
September 21, 2026 09:54
97b59a8 to
4aa97f5
Compare
Prometee
requested changes
Sep 21, 2026
Prometee
left a comment
Prometee
left a comment
Contributor
There was a problem hiding this comment.
@stlgaits This is a sensible safety net, but I’d suggest tightening the constraint to the exact broken range if upstream has confirmed that only the affected Twig 3.29.x line is impacted. As written, twig/twig: 3.29.* blocks every 3.29 release, even for projects that already include the fixed Symfony/Sylius patches. A narrower range (or at least a clear comment with the upstream fix references) will make the workaround easier to remove once the fixed packages are released.
TheMilek
force-pushed
the
twig-conflict
branch
from
September 23, 2026 07:33
4aa97f5 to
fc69294
Compare
loic425
approved these changes
Sep 23, 2026
TheMilek
changed the title
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this
ArgumentCountErrorexception being thrown when using twig/twig 3.29Related :