fix(bootstrap-admin-ui): grid filters header hover in dark mode - #389
Open
camilleislasse wants to merge 1 commit into
Open
camilleislasse wants to merge 1 commit into
camilleislasse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #388
In dark mode, hovering the grid "Filters" accordion header turned its background white, making the text unreadable.
The hover background used the SCSS variable
$gray-100, compiled to#f8f9faregardless of the theme. It now usesvar(--tblr-tertiary-bg), which resolves to the same#f8f9fain light mode (no visual change) and#2b3035in dark mode.Compiled assets (
public/app.css,public/app.rtl.css) are regenerated; only this rule changes.