test(vue-query/useQueries): assert the other query is not refetched when refetching a single query by sukvvon · Pull Request #11608 · TanStack/query

sukvvon · 2026-09-24T05:04:38Z

🎯 Changes

In should refetch only the specific query without affecting others, the second query's queryFn takes 20ms while only 10ms elapse after refetch(), so its data stays 'posts-1' even if it were refetched.

Adds expect(queriesState.value[1].isFetching).toBe(false) so the test fails if refetching the first query also refetches the second.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added a check confirming that refetching one query does not leave another query in a fetching state.

…hen refetching a single query

nx-cloud · 2026-09-24T05:05:00Z

View your CI Pipeline Execution ↗ for commit d17fc1e

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	5m 14s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	11s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-24 05:10:54 UTC

github-actions · 2026-09-24T05:05:49Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-09-24T05:07:01Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11608

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11608

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11608

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11608

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11608

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11608

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11608

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11608

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11608

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11608

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11608

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11608

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11608

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11608

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11608

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11608

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11608

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11608

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11608

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11608

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11608

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11608

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11608

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11608

commit: d17fc1e

coderabbitai · 2026-09-24T05:07:02Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c86581af-9286-424a-8721-9f81f871f7bf

📥 Commits

Reviewing files that changed from the base of the PR and between 7bfe142 and d17fc1e.

📒 Files selected for processing (1)

packages/vue-query/src/__tests__/useQueries.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review.

📝 Walkthrough

Walkthrough

The Vue Query test now checks that refetching the first query does not leave the second query in a fetching state.

Changes

Refetch isolation

Layer / File(s)	Summary
Verify query refetch isolation `packages/vue-query/src/__tests__/useQueries.test.ts`	The test asserts that the second query has `isFetching` set to `false` after the first query is refetched.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to d17fc

The test now detects an unintended refetch of the second query. No actionable merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the added Vue Query test assertion for preventing unrelated query refetches.
Description check	✅ Passed	The description explains the test change and motivation, completes the checklist, and identifies the change as having no release impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-24T05:07:20Z

size-limit report 📦

Path	Size
react full	11.87 KB (0%)
react minimal	8.85 KB (0%)

test(vue-query/useQueries): assert the other query is not refetched w…

d17fc1e

…hen refetching a single query

sukvvon self-assigned this Sep 24, 2026

sukvvon merged commit c9c86ff into main Sep 25, 2026
9 checks passed

sukvvon deleted the test/vue-query-usequeries-refetch-isolation branch September 25, 2026 02:24

Navigation Menu

Uh oh!

test(vue-query/useQueries): assert the other query is not refetched when refetching a single query - #11608

test(vue-query/useQueries): assert the other query is not refetched when refetching a single query#11608
sukvvon merged 1 commit into
mainfrom
test/vue-query-usequeries-refetch-isolation

sukvvon commented Sep 24, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 24, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 24, 2026

Uh oh!

pkg-pr-new Bot commented Sep 24, 2026

Uh oh!

coderabbitai Bot commented Sep 24, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

github-actions Bot commented Sep 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 24, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Sep 24, 2026

Uh oh!

coderabbitai Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-actions Bot commented Sep 24, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 24, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 24, 2026 •

edited

Loading

coderabbitai Bot commented Sep 24, 2026 •

edited

Loading