feat: sync via ws participants in sessions - #73
Draft
maxy-shpfy wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Adds a live participant bar to chat sessions, showing avatars for all humans who have contributed to or are currently connected to a session.
Contributes to https://github.com/Shopify/oasis-frontend/issues/682
What changed?
SessionPresenceclass on the server that ref-counts socket connections per user per session, so a user's presence only drops when their last tab disconnects.buildParticipantshelper that merges message authors (inactive) with currently-connected users (active), sorting active participants first, then alphabetically.session:participantsevent to the room on join and whenever a socket connects or disconnects, keeping every client's roster in sync.ChatJoinPayloadnow includes the joining user'sauthoridentity so the server can attribute presence to the correct author id.SessionParticipantandParticipantsPayloadtypes to the shared contracts.SessionParticipantscomponent that renders a row of overlapping avatars — full color for active users, grayscale for inactive ones.UserAvatargained agrayscaleprop to support the inactive state styling.useSessionChathook tracks the participant roster in state, subscribes tosession:participantsevents, and sends the user's author identity on join. Participant state is cleared on session switch and disconnect.PrimeChatPanelwhen at least one participant is present.How to test?
Why make this change?
Multi-user sessions had no visibility into who else was present or had participated. The participant bar gives users immediate awareness of collaborators — distinguishing who is live in the session from who has contributed historically.