feat: add browser automation settings and fix confirmation waits - #225
Merged
Merged
Conversation
iuyo5678
marked this pull request as ready for review
September 11, 2026 04:34
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can change the extension's Automation settings, but command-line overrides previously took precedence over those visible choices. This change makes the saved browser settings authoritative and fixes the shorter daemon timeout that caused repeated tab-borrow prompts.
The popup provides two independent switches, both enabled by default. With both on, borrowing requires approval and request-help uses the existing UI. Changes apply to existing and new sessions. Re-enabling a setting affects subsequent operations without undoing completed borrows or reopening finished help requests. Descriptions stay in info tooltips, and option labels use smaller, regular-weight text.
The current CLI accepts --unattended, tab borrow --no-confirm, and BSK_REQUEST_HELP=off for compatibility but reports them as deprecated. It does not use them to override browser settings. The current daemon ignores its inherited help override and strips legacy borrow overrides before forwarding, including when connected to an older extension. Help requests reaching the current daemon go to the owning extension. Missing confirmation wiring returns an error instead of granting approval.
Protocol 1.3 keeps the base handshake floor at 1.0, allowing staggered CLI and extension upgrades. Ordinary sessions and default tab borrowing remain available with compatible older peers. The popup explains older-daemon limitations and clears that guidance after an update; saved switch values are preserved. Protocol major mismatches and peer-declared incompatible floors are still rejected.
Feature requirements are limited to the affected operations:
The original timeout fixes remain: current daemon and CLI budgets cover the 60-second confirmation UI plus cleanup grace. Deadlines dismiss pending UI; completed borrows are idempotent; pending duplicates, user denial, timeout, unavailable UI, and uncertain move outcomes remain distinct. Changing --timeout never changes whether approval is required.
Preference-read failures retain known values or default to both settings enabled, without persisting fallback defaults or blocking session creation. Later reads and storage events recover saved values; popup reads and writes remain strict. When help is disabled, the skill directs the agent to re-observe and continue authorized work within available capabilities. Disabled does not mean completed or grant permission. CLI and DSH skills preserve user-tab isolation and host rules.
Validation:
Final commit:
0170852. All four CI jobs and the repository open-source scan passed.