Fix for admin having no (execute) rights on private projects/tplans

[kostgr]

We've experienced issue with global admins having no testplan execution right on some private projects / testplans (he could go to execution, but at the bottom of the Testcase description there was no area with execution notes and with buttons for marking test as blocked/successfull/failed).

For some reason the global admins are not always assigned an admin role on all of the projects/testplans. For the public projects and public testplans it is not an issue. But if project of testplan is private, than the $user->hasRight() returns false (I'm not sure about it => has debugged with vim and by trial and error, but that was my conclusion).
In the execSetResults controller it lead to an effect, that the user was identified as having no execution right.

It would be possibly better to ignore public-Attributes for global admins, but I've taken the simpler way (I'm not an php-Developer, so I've searched for the simplest way).

I had to add exception for exec_ro_access, because otherwise the wrong description (wrong menu item) was shown on the home for admins - "Show the exections RO" or something like this - instead of "Execute tests" (I've used the german language and haven't noticed the text exactly).

[fmancardi]

Need to recheck and do some tests before accepting this merge request.

[daring123]

There is no place for me to create issue, So I ask my question here.
We use testlink ( the version is 1.9.13) to manage our testcases .However, when testcases are up to 1000.The testlink will be very slow.
What's more,when I add testcases to my test plan.It takes 9 seconds to render the tpl. Why?

[kostgr]

If you have too much testcases in a suite - split up a suite, use filters (not assigned testcases, testcases status etc.), take a look at the settings (something with loading of tree and of the testcases for subsuites).
But it is really wrong place for such a questions - you'd better sign up for forum and ask there. I'm not experienced enouph to help you further.

[fmancardi]

Issues has to be openen on http://mantis.testlink.org