Skip to content

fix details no effect for api getTestCasesForTestPlan #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
264768502 wants to merge 4 commits into
base: testlink_1_9
Choose a base branch
from
Open

fix details no effect for api getTestCasesForTestPlan #160

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e9397b
fix details no effect for api getTestCasesForTestPlan
264768502 Apr 17, 2018
ba6f5e0
add return tsuite_id
264768502 Apr 17, 2018
1879c5e
add return execution_notes
264768502 Apr 17, 2018
1ba9cb9
add execution_ts info return
264768502 Apr 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions lib/functions/testplan.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6842,6 +6842,15 @@ public function getLTCVNewGeneration($id,$filters=null,$options=null)
$my[$mk] = array_merge($my[$mk], (array)$$mk);
}

switch($my['options']['details'])
{
case 'full':
$my['options']['addPriority'] = true;
$my['options']['addImportance'] = true;
$my['options']['testSuiteInfo'] = true;
break;
}

if( !is_null($sql2do = $this->getLinkedTCVersionsSQL($id,$my['filters'],$my['options'])) )
{
// need to document better
Expand Down Expand Up @@ -7041,7 +7050,7 @@ function getLinkedTCVersionsSQL($id,$filters=null,$options=null)

if($my['options']['addExecInfo'])
{
$commonFields .= ",COALESCE(E.id,0) AS exec_id,E.tcversion_number,E.build_id AS exec_on_build,E.testplan_id AS exec_on_tplan";
$commonFields .= ",COALESCE(E.id,0) AS exec_id,E.tcversion_number,E.build_id AS exec_on_build,E.testplan_id AS exec_on_tplan, E.execution_ts, E.notes as execution_notes ";
}

if($my['options']['specViewFields'])
Expand All @@ -7053,7 +7062,7 @@ function getLinkedTCVersionsSQL($id,$filters=null,$options=null)
$my['join']['tsuites'] = '';
if($my['options']['testSuiteInfo'])
{
$commonFields .= ",NH_TSUITE.name AS tsuite_name ";
$commonFields .= ",NH_TSUITE.name AS tsuite_name, NH_TSUITE.id AS tsuite_id ";
$my['join']['tsuites'] = " JOIN {$this->tables['nodes_hierarchy']} NH_TSUITE " .
" ON NH_TSUITE.id = NH_TCASE.parent_id ";
}
Expand Down Expand Up @@ -8466,4 +8475,4 @@ function get_all_by_testplan($tplan_id)
}


} // end class milestone_mgr
} // end class milestone_mgr