Skip to content

fix(SheetBoard): stop double-applying devicePixelRatio to the scissor/viewport rect #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rihokirss wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(SheetBoard): stop double-applying devicePixelRatio to the scissor/viewport rect #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions packages/obc/src/core/SheetBoard/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,6 @@ export class SheetBoard extends LitElement {
const hostRect = this.getBoundingClientRect();
const hostW = hostRect.width;
const hostH = hostRect.height;
const dpr = window.devicePixelRatio;

// Clear the whole canvas to transparent first.
renderer.setScissorTest(false);
Expand Down Expand Up @@ -666,14 +665,18 @@ export class SheetBoard extends LitElement {
if (sx + sw <= 0 || sx >= hostW || sy + sh <= 0 || sy >= hostH)
continue;

// Convert to WebGL coords: origin bottom-left, device pixels.
const glX = Math.round(sx * dpr);
const glY = Math.round((hostH - sy - sh) * dpr);
const glW = Math.round(sw * dpr);
const glH = Math.round(sh * dpr);

renderer.setScissor(glX, glY, glW, glH);
renderer.setViewport(glX, glY, glW, glH);
// Convert to WebGL coords: origin bottom-left. These stay in CSS
// pixels — setScissor() and setViewport() multiply by the renderer's
// own pixel ratio internally, and the canvas was sized with
// setSize() in CSS pixels too, so scaling here as well would apply
// devicePixelRatio twice.
const vpX = Math.round(sx);
const vpY = Math.round(hostH - sy - sh);
const vpW = Math.round(sw);
const vpH = Math.round(sh);

renderer.setScissor(vpX, vpY, vpW, vpH);
renderer.setViewport(vpX, vpY, vpW, vpH);
renderer.setClearColor(0xffffff, 1);
renderer.clear();
renderer.render(scene, vp.camera);
Expand Down