feat: add activity selection problem (greedy algorithms) - #3208
Open
humaisali wants to merge 2 commits into
Open
feat: add activity selection problem (greedy algorithms)#3208humaisali wants to merge 2 commits into
humaisali wants to merge 2 commits into
Conversation
Author
|
Hi @Panquesito7 & @realstealthninja, this is my first contribution to the project. I've implemented the Activity Selection Problem as a new greedy algorithm following the guidelines in CONTRIBUTING.md - Doxygen documentation, snake_case naming, self-contained tests with assert(), and formatting/static analysis checked against the repo's own .clang-format and .clang-tidy configs. Whenever you get a chance, I'd really appreciate a review. Happy to make any changes needed. Thanks for maintaining this project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds a new greedy algorithm implementation: the Activity Selection Problem
(
greedy_algorithms/activity_selection.cpp). Given a set of activities eachwith a start and finish time, the algorithm selects the maximum number of
non-overlapping activities that a single resource can perform, using the
classic greedy strategy of always choosing the next activity with the
earliest finish time. Runs in O(n log n) due to the sort step.
This algorithm was not previously present anywhere in the repository (I
searched the codebase across all directories before implementing it).
Checklist
Notes: New greedy algorithm implementation, Activity Selection Problem, with 5 self-tests covering normal, single-activity, empty-input, fully-overlapping, and non-overlapping cases.