style: apply automated formatting baseline with clang-format

[DevGeniusCode]

Prerequisites: Please Merge First

This PR is the final step of the formatting baseline. It depends on two preliminary structural PRs that must be merged first to ensure a clean, 100% automated formatting pass without breaking VC6 compilation:

1. chore: Prevent conflict between clang-format and pre-C++11 nested template parsing #2760 - Handle nested templates to prevent >> merging in C++98.
2. refactor: Eliminate macro-split assignments #2641 - Eliminates macro-split assignments for clean AST parsing.

---

Objective

This PR introduces a minimalist, non-destructive .clang-format baseline. To make this easy to review and discuss, I have scoped the formatting only to the .\Core\GameEngine directory.

The "Do No Harm" Approach

The primary goal of this configuration is to avoid the "destructive" behavior of standard formatters.

• ColumnLimit: 0: Automatic line wrapping is completely disabled. Clang-format will respect our manual line breaks and will not pack or split arguments unexpectedly.

What is being formatted?

To establish a consistent baseline, the formatter enforces a few core rules:

1. Tabs & Indentation: Enforces Tabs for indentation with a width of 2.
2. Braces (Allman Style): Standardizes to the Allman style (braces on new lines).
   Why this change was made -now-: clang-format fundamentally requires a brace style to function; it cannot simply "ignore" braces even on a pure whitespace pass. Since running the tool was inevitably going to touch braces and affect line counts anyway, I decided to "go all in" and establish a fully consistent style across the board, rather than trying to fight the tool to maintain an inconsistent legacy mix.
3. Pointers: Enforces Left-aligned pointers (e.g., void* ptr).
4. Trailing Comments: Vertical alignment is disabled (AlignTrailingComments: false) with a fixed 5-space offset. This prevents "diff pollution" (the ripple effect where adding one long function name forces all surrounding comments to shift).
5. Escaped Newlines: Macro line continuations (\) are left-aligned (AlignEscapedNewlines: DontAlign) with a single space. This eliminates the "mixed whitespace" anti-pattern and ensures macros render perfectly straight in GitHub and all IDEs, regardless of the user's tab width setting.

Legacy / VC6 Compatibility

A lot of effort went into making sure this doesn't break our legacy support:

• Zero Manual Overrides: Because the structural blockers (nested templates and macro splits) are handled in the prerequisite PRs, this configuration successfully parses and formats the legacy codebase automatically. We use Standard: c++20 to correctly parse modern syntax while maintaining VC6 compatibility structurally.
• Macro Handling: I added custom rules (AttributeMacros and Macros) to safely parse our CPP_11 enum macros without breaking the formatting tree.
• Short Blocks: Kept AllowShortBlocksOnASingleLine: Always so macros and empty stubs aren't vertically bloated.

Future Phases (Minimizing the Initial Diff)

Please note that several settings in this baseline (such as SortIncludes: false, AllowShortFunctionsOnASingleLine: All, and AllowShortBlocksOnASingleLine: Always) are intentionally included purely to minimize the initial diff and avoid overwhelming changes.

[greptile-apps]

Greptile Summary

This PR introduces a .clang-format baseline scoped to Core/GameEngine, enforcing Allman brace style, 2-space tab indentation, left-aligned pointers, and disabling line wrapping — with 369 files reformatted automatically.

• Configuration gaps in .clang-format: Cpp11BracedListStyle is unset (defaults to true), so aggregate and array initializer opening braces land K&R-style (= {) rather than Allman, and the closing brace can end up on the same line as the last element (e.g., nullptr} in Damage.cpp). Additionally, AlignConsecutiveDeclarations/AlignConsecutiveAssignments are absent (default None), which strips the intentional column alignment from data-oriented blocks — conflicting with the team's data-block alignment rule.
• Macros expansion side-effect: The Macros: - CPP_11(x)=x definition causes the formatter to expand and reformat the macro argument, injecting a space inside every CPP_11(: Int) call site (it becomes CPP_11( : Int)) across GameType.h, GameCommon.h, and other files.
• Standard: c++20 still present: Previously acknowledged in review discussion and noted to be addressed in a follow-up PR.

Confidence Score: 5/5

Safe to merge; all changes are whitespace and brace reformatting with no semantic modifications to game logic.

The entire changeset is automated whitespace formatting — no logic, data, or API contracts are altered. The configuration gaps identified are cosmetic inconsistencies with the stated goals rather than bugs that would break compilation or runtime behavior.

.clang-format deserves a second look for the three configuration gaps before additional files are brought under this baseline.

Important Files Changed

Filename	Overview
.clang-format	New formatter configuration introducing Allman brace style, tab indentation, and left-aligned pointers; has three notable gaps: aggregate initializer brace placement (Cpp11BracedListStyle unset), missing AlignConsecutiveDeclarations/Assignments stripping data-block alignment, and Macros expansion injecting spaces inside CPP_11() calls.
Core/GameEngine/Source/GameLogic/System/Damage.cpp	Pure whitespace/brace reformatting; notable artifact is the s_bitNameList array closing brace landing on the same line as nullptr (nullptr}) due to unset Cpp11BracedListStyle.
Core/GameEngine/Include/Common/GameType.h	Reformatted; loses tab-aligned columns for DEFAULT_WORLD_WIDTH/HEIGHT macros; CPP_11(: Int) gains a spurious space becoming CPP_11( : Int) across all enum declarations in this file.
Core/GameEngine/Source/Common/System/GameMemory.cpp	Reformatted; debug-mode constant block loses aligned = signs; #include inside #ifdef now indented by IndentPPDirectives: BeforeHash.
Core/GameEngine/Source/Common/System/GameMemoryInitPools_Generals.inl	PoolSizes[] array opening brace moves from Allman to K&R placement due to Cpp11BracedListStyle default; data rows and values unchanged.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[.clang-format baseline] --> B[BraceWrapping: Allman]
    A --> C[ColumnLimit: 0]
    A --> D[UseTab: AlignWithSpaces]
    A --> E[Macros: CPP_11 x =x]
    A --> F[AlignConsecutive*: unset]
    A --> G[Cpp11BracedListStyle: unset]

    B --> B1[✓ class/function/namespace/if braces → Allman]
    B --> B2[✗ aggregate/array initializers → K&R via Cpp11BracedListStyle default]

    E --> E1[✓ Parses CPP_11 enum macros without tree break]
    E --> E2[⚠ Injects space: CPP_11 colon Int → CPP_11 space colon Int]

    F --> F1[⚠ Strips column alignment from data blocks]

    G --> G1[⚠ Opening brace on same line for list initializers]
    G1 --> G2[Closing brace may land on last element line]

Loading

Prompt To Fix All With AI

Fix the following 3 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 3
.clang-format:74-75
**`Macros` expansion injects spaces inside `CPP_11()` call sites**

The `Macros: - CPP_11(x)=x` definition tells clang-format to expand `CPP_11(: Int)` to `: Int` before reformatting. In that expanded context the formatter treats `:` as an enum base-clause token and adds spacing around it, then re-emits the result back inside the parentheses — producing `CPP_11( : Int)` instead of `CPP_11(: Int)` across all call sites in `GameType.h`, `GameCommon.h`, and the broader codebase. This is observable in the diff: every `enum X CPP_11(: Int)` becomes `enum X CPP_11( : Int)`. While it doesn't affect compilation, it is an unintended whitespace change inside macro arguments caused by the Macros config interacting with `SpacesInParentheses: false`.

### Issue 2 of 3
.clang-format:69-70
**`BraceWrapping` does not apply to aggregate/array initializers**

The Allman brace style configured via `BraceWrapping` only covers classes, functions, namespaces, enums, etc. — it does not govern aggregate initializers or array initializers. As a result, declarations like `static PoolSizeRec PoolSizes[] =\n{` (Allman) become `static PoolSizeRec PoolSizes[] = {` (K&R), and the closing `}` in `Damage.cpp` ends up on the same line as the last element (`nullptr}`). This is a known clang-format limitation: aggregate brace placement is controlled by `Cpp11BracedListStyle`, which is unset here and defaults to `true` (K&R for list initializers). If consistent Allman style across all brace contexts is desired, `Cpp11BracedListStyle: false` would be needed.

### Issue 3 of 3
.clang-format:38-39
**Formatter removes column alignment in data-oriented blocks**

Neither `AlignConsecutiveDeclarations` nor `AlignConsecutiveAssignments` are configured, so both default to `None`. This causes the formatter to strip the intentional column alignment from data-oriented blocks across the codebase. For example, `GameType.h` loses the aligned spacing between `DEFAULT_WORLD_WIDTH`/`DEFAULT_WORLD_HEIGHT` and their values; `AsciiString.h` loses alignment between the two `unsigned short` member declarations; `GameMemory.cpp` loses the aligned `=` signs in its debug constant block. The team's rule requires maintaining column alignment in data blocks and lookup tables — the current config actively removes it.

_{Reviews (6): Last reviewed commit: "style: fix whitespace in typedefs and it..." | Re-trigger Greptile}

[Skyaero42]

First initial impression.

Generic comment:

Tabs & Indentation: Enforces Tabs for indentation with a width of 2.

This is an incorrect description. Indentation width of tabs is determined by the IDE. VS defaults to 2.

[DevGeniusCode]

There are still a few formatting improvements I haven’t addressed in this pass, such as consecutive assignment alignment.

Current (Before):

AudioAffect_Music = 0x01,
AudioAffect_Sound = 0x02,
AudioAffect_Sound3D = 0x04,
AudioAffect_All = (Music | Sound | Sound3D),

Target (After):

AudioAffect_Music   = 0x01,
AudioAffect_Sound   = 0x02,
AudioAffect_Sound3D = 0x04,
AudioAffect_All     = (Music | Sound | Sound3D),

If there is interest, I can implement it

[xezon]

AudioAffect_Music = 0x01,
AudioAffect_Sound = 0x02,
AudioAffect_Sound3D = 0x04,
AudioAffect_All = (Music | Sound | Sound3D),

This is good.

[xezon]

It does look promising.

[DevGeniusCode]

Updated

[xezon]

Looks very promising again. I like the minimal formatting on this first pass. Just a few more things to polish.

[xezon]

The block macros are indented with 2 spaces instead of tabs. In the github page they will show with different indent width.

[xezon]

Also strange that here the block comment has only 1 leading space.

[DevGeniusCode]

Updated