feat(replay): Check CRC messages from all players in replays#2649
Draft
Caball009 wants to merge 1 commit into
Draft
feat(replay): Check CRC messages from all players in replays#2649Caball009 wants to merge 1 commit into
Caball009 wants to merge 1 commit into
Conversation
Caball009
added
Enhancement
Caball009
force-pushed
the
feat_replay_check_all_crc
branch
4 times, most recently
from
6b0ab7d to
b2e84cd
Compare
Caball009
force-pushed
the
feat_replay_check_all_crc
branch
4 times, most recently
from
ea2f91d to
2bf436a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original behavior wrt replays is that only the CRC messages from the player that recorded the replay are checked. This means that players can experience a 'live' mismatch, but the game won't show the mismatch for their replay if they didn't cause it.
This PR changes the default behavior so the CRC messages from all players are checked. I also added an opt-out command line
-replayLocalPlayerCRCbecause developers with large replay collections may want to rely on the original behavior. As a small bonus the name of the mismatching player is now displayed on screen if it's possible to determine which player is responsible.Before:
replay_crc_before.mp4
After:
replay_crc_after.mp4
TODO: